This repository has been archived by the owner on May 21, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 994
Add gzip compression option for the JWT Claims part #102
Closed
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,103 @@ | ||
package jwt | ||
|
||
import ( | ||
"bytes" | ||
"compress/gzip" | ||
"fmt" | ||
"io/ioutil" | ||
) | ||
|
||
var ( | ||
// CompressionNone does not perform any data compression/decompression | ||
CompressionNone CompressionMethod | ||
// CompressionGzip compresses the claims part of the JWT with gzip algorithm | ||
CompressionGzip CompressionMethod | ||
) | ||
|
||
var ( | ||
compressionMethods map[string]CompressionMethod | ||
) | ||
|
||
// CompressionMethod is an interface used to compress/decompress the Claims part of the JWT | ||
type CompressionMethod interface { | ||
// Alg returns the name of the compression algorithm. It is saved in the token header | ||
Alg() string | ||
// Compress takes uncompressed data, and returns the compression result` | ||
Compress(data []byte) ([]byte, error) | ||
// Decompress takes compressed data and returns uncompressed version | ||
Decompress(data []byte) ([]byte, error) | ||
} | ||
|
||
type compressionGzip struct{} | ||
|
||
type compressionNone struct{} | ||
|
||
func (c *compressionGzip) Alg() string { | ||
return "gzip" | ||
} | ||
|
||
func (c *compressionGzip) Compress(data []byte) ([]byte, error) { | ||
var buffer = &bytes.Buffer{} | ||
var writer = gzip.NewWriter(buffer) | ||
|
||
if _, err := writer.Write(data); err != nil { | ||
writer.Close() | ||
return nil, err | ||
} | ||
|
||
writer.Close() | ||
return buffer.Bytes(), nil | ||
} | ||
|
||
func (c *compressionGzip) Decompress(data []byte) ([]byte, error) { | ||
var buffer = bytes.NewBuffer(data) | ||
var reader, err = gzip.NewReader(buffer) | ||
defer reader.Close() | ||
if err != nil { | ||
return nil, err | ||
} | ||
|
||
return ioutil.ReadAll(reader) | ||
} | ||
|
||
func (c *compressionNone) Alg() string { | ||
return "none" | ||
} | ||
|
||
func (c *compressionNone) Compress(data []byte) ([]byte, error) { | ||
return data, nil | ||
} | ||
|
||
func (c *compressionNone) Decompress(data []byte) ([]byte, error) { | ||
return data, nil | ||
} | ||
|
||
// RegisterCompressionMethod adds support for additional compression method in the runtime. | ||
// The name value is saved in the token header and later used to retrieve the method interface | ||
// used to decompress the header | ||
func RegisterCompressionMethod(name string, method CompressionMethod) { | ||
compressionMethods[name] = method | ||
} | ||
|
||
func getCompressionMethod(alg interface{}) (CompressionMethod, error) { | ||
var algString, ok = alg.(string) | ||
if ok == false || len(algString) == 0 { | ||
return compressionMethods["none"], nil | ||
} | ||
|
||
var method = compressionMethods[algString] | ||
if method == nil { | ||
return nil, fmt.Errorf("Compression method %s not registered", alg) | ||
} | ||
|
||
return method, nil | ||
} | ||
|
||
func init() { | ||
CompressionNone = &compressionNone{} | ||
CompressionGzip = &compressionGzip{} | ||
|
||
compressionMethods = make(map[string]CompressionMethod) | ||
compressionMethods["none"] = CompressionNone | ||
compressionMethods["gzip"] = CompressionGzip | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
package jwt_test | ||
|
||
import ( | ||
"strings" | ||
"testing" | ||
|
||
"github.com/dgrijalva/jwt-go" | ||
) | ||
|
||
func TestNewTokenWithGzipCompression(t *testing.T) { | ||
var token = jwt.New(jwt.SigningMethodHS256, jwt.CompressionGzip) | ||
|
||
token.Claims = map[string]interface{}{ | ||
"claim1": "testvalue1", | ||
"claim2": 42, | ||
} | ||
|
||
var tokenString, err = token.SignedString([]byte("TEST KEY")) | ||
if err != nil { | ||
t.Errorf("Error signing gzip compressed claims: %s", err) | ||
} | ||
|
||
parts := strings.Split(tokenString, ".") | ||
if len(parts) != 3 { | ||
t.Errorf("Token string has %d parts", len(parts)) | ||
} | ||
if parts[1] != "H4sIAAAJbogA_6pWSs5JzMw1VLJSKkktLilLzClNNVTSgYgaKVmZGNUCAgAA__9vre6IIwAAAA" { | ||
t.Error("Token claims not encoded properly") | ||
} | ||
} | ||
|
||
func TestNewTokenWithWrongCompressionAlg(t *testing.T) { | ||
var token = jwt.New(jwt.SigningMethodHS256, jwt.CompressionNone) | ||
token.Header["cpr"] = "dummy" // set wrong compression method | ||
token.Claims = map[string]interface{}{ | ||
"claim1": "testvalue1", | ||
"claim2": 42, | ||
} | ||
|
||
var _, err = token.SignedString([]byte("TEST KEY")) | ||
if err == nil { | ||
t.Errorf("Expected error") | ||
} else if err.Error() != "Compression method dummy not registered" { | ||
t.Errorf("Unexpected error description: %s", err.Error()) | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this may break older versions of the token