Implemented Error trait for PyErr #126
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eijebong
suggested changes
Feb 21, 2018
src/err.rs
Outdated
| @@ -394,6 +396,21 @@ impl <'p> std::convert::From<PythonObjectDowncastError<'p>> for PyErr { | |||
| } | |||
| } | |||
|
|
|||
| impl Error for PyErr { | |||
|
|
|||
src/err.rs
Outdated
| } | ||
|
|
||
| impl fmt::Display for PyErr { | ||
|
|
|
Fixed |
|
Waiting for this to be merged. Is it because Travis failed? Seems like it cannot compile some test - but this seems to not be caused by this PR (?) |
|
I sync'd my branch with master and it appears to have fixed the error with the doctest however there is a new error with nightly. Not really sure what is causing it. |
dgrunwald
reviewed
Apr 24, 2020
|
|
||
| impl fmt::Display for PyErr { | ||
| fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { | ||
| write!(f, "PyErr: ptype {:?} pvalue {:?}", self.ptype, self.pvalue) |
There was a problem hiding this comment.
I would expect Display to result in something like str(e) in Python.
This code here is more like repr(type(e)) + repr(e), except even weirder if the exception is not yet initialized (PyErr::new_lazy_init).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for more flexibility for converting between error types.
Relevant issue: #125