feat: Make compatible with Python 2 and Python 3 runtimes #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewfeickert
force-pushed
the
feat/make-python2-python3-compatible
branch
from
895e842
to
d6746fc
Compare
matthewfeickert
force-pushed
the
feat/make-python2-python3-compatible
branch
from
d6746fc
to
ad7f688
Compare
|
@dguest This is ready for review. We don't have CI yet, but I've been dogfooding this on atlasconnect and things work fine with Python2 still. |
|
🤘 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #23 (might still be treated as Python 2 by default)
Use
tryandexceptblocks in the library imports to properly load the libraries that are divergent across Python 2 and Python 3. (Currently also showing the work of another PR)pandamonpanda-shortnamepanda-resub-taskidpanda-kill-taskid