Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Migrate from pep517 to python-build #33

Merged

Conversation

matthewfeickert
Copy link
Collaborator

Switch from using the now deprecated pep517 to build sdist and wheels to the new python-build library. c.f. scikit-hep/pyhf#1066 for more context.

(I forgot to migrate this over into PR #29 once we learned about this for pyhf).

Suggested squash and merge commit message

* Migrate from the deprecated pep517.build to python-build CLI for builds for packaging
   - c.f. https://github.com/pypa/pep517/pull/83
* Remove check stage as done implicitly with python-build

@matthewfeickert matthewfeickert marked this pull request as ready for review September 22, 2020 08:14
@matthewfeickert
Copy link
Collaborator Author

@dguest This is ready for review (sorry I forgot to update PR #29 with this when I learned about the change last week).

@dguest dguest merged commit bf95550 into dguest:master Sep 22, 2020
@matthewfeickert matthewfeickert deleted the chore/migrate-from-pep517-to-build branch September 22, 2020 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants