Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies #4

Merged
merged 1 commit into from
Mar 25, 2023
Merged

Upgrade dependencies #4

merged 1 commit into from
Mar 25, 2023

Conversation

dguo
Copy link
Owner

@dguo dguo commented Mar 25, 2023

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #4 (d6a40ad) into main (dc2de8f) will decrease coverage by 2.46%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main       #4      +/-   ##
==========================================
- Coverage   33.80%   31.34%   -2.46%     
==========================================
  Files           2        2              
  Lines          71       67       -4     
  Branches       22       21       -1     
==========================================
- Hits           24       21       -3     
+ Misses         47       40       -7     
- Partials        0        6       +6     
Impacted Files Coverage Δ
source/index.ts 28.12% <ø> (-2.76%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@@ -1,7 +1,6 @@
import crypto from "crypto";

import axios, {AxiosInstance} from "axios";
import rax from "retry-axios";
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropping retry-axios because of an import error with TS: JustinBeckwith/retry-axios#193 (comment)

It also apparently doesn't work with the latest versions of Axios anyway.

axios-retry looks like an easy enough replacement for a subsequent PR.

@dguo dguo merged commit 02766e8 into main Mar 25, 2023
@dguo dguo deleted the upgrade branch March 25, 2023 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants