Write waifu suggestions directly to a file #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I decided that the complexity of caching suggestions to `bot.db` isn't worth it. Savings on SSD wear are likely to be negligible as this feature doesn't see heavy use, and it's actually *more* likely to lose data that's only cached in `bot.memory` if the bot crashes or otherwise fails to shut down gracefully. Plus, plugin values in the database will be truncated to a fairly short length on certain DB backends (see issue tracking this upstream, sopel-irc/sopel#2291). Tested live adding a few waifus, viewed the file (making sure newlines were handled correctly), and then used `.clearwaifus` to delete it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I decided that the complexity of caching suggestions to
bot.dbisn't worth it. Savings on SSD wear are likely to be negligible as this feature doesn't see heavy use, and it's actually more likely to lose data that's only cached inbot.memoryif the bot crashes or otherwise fails to shut down gracefully. Plus, plugin values in the database will be truncated to a fairly short length on certain DB backends (see issue tracking this upstream, sopel-irc/sopel#2291).Tested live adding a few waifus, viewed the file (making sure newlines were handled correctly), and then used
.clearwaifusto delete it.