Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script to detect duplicate JSON keys #44

Merged
merged 2 commits into from
Sep 8, 2024
Merged

Conversation

dgw
Copy link
Owner

@dgw dgw commented Sep 8, 2024

Additional GitHub Actions check using the new script also included, and updated the Makefile recipe to run this check locally.

Resolves #28.

Edit: Of course, GHA doesn't run the workflow for this PR this because it's looking for changes to the JSON.

Additional GitHub Actions check using the new script also included, and
updated the Makefile recipe to run this check locally.
@dgw dgw added the enhancement New feature or request label Sep 8, 2024
@dgw dgw added this to the 1.0.0 milestone Sep 8, 2024
It's nice to verify that the edited checks work before merging said PR,
and the workflow has to actually run for verification to happen.
@dgw
Copy link
Owner Author

dgw commented Sep 8, 2024

Hooray, small edit to the workflow and it's now validated as part of the PR.

@dgw dgw merged commit 85a9d43 into master Sep 8, 2024
3 checks passed
@dgw dgw deleted the detect-duplicate-keys branch September 8, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enforce unique series name keys somehow
1 participant