Update Genshin Impact characters #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is mostly NPCs. Units are mostly unchanged, except for sort order now matching the order at HoYoLAB. https://wiki.hoyolab.com/pc/genshin/aggregate/2 (characters) https://wiki.hoyolab.com/pc/genshin/aggregate/10 (NPCs)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly NPCs. Units are mostly unchanged, except for sort order now matching the order at HoYoLAB.
https://wiki.hoyolab.com/pc/genshin/aggregate/2 (characters)
https://wiki.hoyolab.com/pc/genshin/aggregate/10 (NPCs)
And yeah, this was exhausting. Took probably an hour, and I'm still not very confident of it because HoYoLAB's wiki has terrible navigation (every click is a new tab, and you can't middle-click to open a bunch of entries in new tabs at once) and no character metadata; even surnames are absent in most cases.