-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
integrate numpy datetime64 for greater range of years #77
Comments
next steps:
|
Use numpy datetime64 instead of datetime.date #77
@ColeDCrawford as I close this out, I remembered you wanted some benchmarking / assessment on the numpy inclusion. The test suite is pretty fast either way, and we've also been expanding the functionality in other ways, so it's not a strict comparison. Running a checkout of the 0.2 tag, I get
Running in current develop, I get
I compared the virtualenv size when installing version 0.2 and current develop. Without numpy, the virtualenv is 14MB; with numpy it's 46MB. Looking at the folders in the sitep ackages for the latter, the numpy folder is 31MB on its own. Let me know if you think any of this needs to be documented in the changelog or elsewhere. |
Nice, thanks for remembering that. Seems like a negligible performance difference with the main change being the payload size, but we knew about that going in. I think it would be nice to note in the changelog for the v1.0 release |
benchmarking / documentation:
The text was updated successfully, but these errors were encountered: