-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial data model #1
Conversation
Co-authored-by: Cole Crawford <16374762+ColeDCrawford@users.noreply.github.com>
In my local env the same pytest assertion fails. |
tests/test_undate.py
Outdated
|
||
def test_open_range(): | ||
# 900 - | ||
assert str(UndateInterval(Undate(900))) == "0900/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be fixed by removing the leading 0 : "0900/" -> "900/". Is this a cleaning that you where expecting? I think this goes back to how edtf treads leading zeros, but it is not yet implemented.
Fix CI
Looks good to me as a start now. |
For me the tests are failing now. It expects |
included in this PR:
notes
datetime
for convenience even though we know it has some limitations; would be great to have test cases outside of the range supported bydatetime
so we can rework the internals and persist existing behavior articulated in the tests