Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement python version text matrix; move black check to PR only #30

Merged
merged 5 commits into from
Nov 10, 2022
Merged

Implement python version text matrix; move black check to PR only #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c6108ab
Implement python version text matrix; move black check to PR only
rlskoeser Nov 10, 2022
d7e7b32
Use strings for python versions so 3.10 doesn't turn into 3.1
rlskoeser Nov 10, 2022
cb23d60
Add badges to readme for unit tests, python black, and apache 2 license
rlskoeser Nov 10, 2022
efc72fb
Update python versions in setup.py to match tested versions
rlskoeser Nov 10, 2022
7deb812
Rename workflow to "style check"
rlskoeser Nov 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions .github/workflows/check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
name: style check

on:
pull_request:

jobs:
check:
runs-on: ubuntu-latest

defaults:
run:
working-directory: .

steps:
- uses: actions/checkout@v3
- name: Set up Python 3.9
uses: actions/setup-python@v4
with:
python-version: 3.9
cache: 'pip'
cache-dependency-path: '**/setup.py'
- name: Install package with dependencies
run: pip install -e ".[dev]"
if: steps.python-cache.outputs.cache-hit != 'true'
- name: Run black
run: black undate --check --diff
11 changes: 6 additions & 5 deletions .github/workflows/ci.yml → .github/workflows/unit_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: CI
name: unit tests

on:
push:
Expand All @@ -10,8 +10,11 @@ on:
pull_request:

jobs:
qa:
python-unit:
runs-on: ubuntu-latest
strategy:
matrix:
python: ["3.8", "3.9", "3.10", "3.11"]
defaults:
run:
working-directory: .
Expand All @@ -21,13 +24,11 @@ jobs:
- name: Set up Python 3.9
uses: actions/setup-python@v4
with:
python-version: 3.9
python-version: ${{ matrix.python }}
cache: 'pip'
cache-dependency-path: '**/setup.py'
- name: Install package with dependencies
run: pip install -e ".[dev]"
if: steps.python-cache.outputs.cache-hit != 'true'
- name: Run black
run: black undate --check --diff
- name: Run unit tests
run: pytest
3 changes: 3 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@

Repository for the DHTech 2022 Hackathon

[![License](https://img.shields.io/badge/License-Apache_2.0-blue.svg)](https://opensource.org/licenses/Apache-2.0)
[![unit tests](https://github.com/dh-tech/hackathon-2022/actions/workflows/unit_tests.yml/badge.svg)](https://github.com/dh-tech/hackathon-2022/actions/workflows/unit_tests.yml)
[![Code style: black](https://img.shields.io/badge/code%20style-black-000000.svg)](https://github.com/psf/black)

## License

Expand Down
2 changes: 2 additions & 0 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@
"Programming Language :: Python :: 3",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Topic :: Software Development :: Libraries :: Python Modules",
"Topic :: Utilities",
"Typing :: Typed",
Expand Down