Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type cleanup based on errors reported by mypy #66

Merged
merged 9 commits into from
Apr 25, 2024
Merged

Conversation

rlskoeser
Copy link
Member

per #29 — trying out mypy and updating our type annotations based on the reported errors (not all resolved)

I'm installing and checking manually for now:

pip install mypy
mypy --install-types
mypy src/

here are the errors being reported now, after the changes made in this branch:

src/undate/undate.py:145: error: "BaseDateFormat" not callable  [operator]
src/undate/undate.py:146: error: Incompatible types in assignment (expression has type "Optional[BaseDateFormat]", variable has type "BaseDateFormat")  [assignment]
src/undate/undate.py:246: error: Syntax error in type annotation  [syntax]
src/undate/undate.py:246: note: Suggestion: Use Tuple[T1, ..., Tn] instead of (T1, ..., Tn)
Found 3 errors in 1 file (checked 5 source files)

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.66%. Comparing base (ff3ea6d) to head (ca8bdc8).
Report is 12 commits behind head on develop.

❗ Current head ca8bdc8 differs from pull request most recent head b679afa. Consider uploading reports for the commit b679afa to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #66      +/-   ##
===========================================
- Coverage    98.71%   98.66%   -0.06%     
===========================================
  Files            5        4       -1     
  Lines          234      224      -10     
===========================================
- Hits           231      221      -10     
  Misses           3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rlskoeser rlskoeser merged commit e27fe84 into develop Apr 25, 2024
5 checks passed
@rlskoeser rlskoeser deleted the feature/try-mypy branch April 25, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant