Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preliminary edtf parsing (levels 0 and some of 1) with lark #67

Merged
merged 7 commits into from
Apr 25, 2024

Conversation

rlskoeser
Copy link
Member

@rlskoeser rlskoeser commented Nov 3, 2023

parsing for subset of EDTF (dates only, not date time) using lark

  • parser code and grammar (preliminary, very simple tests)
  • transformer code that converts parsetree to undate objects

does not yet handle all cases; undate doesn't currently support EDTF level 2 aspects that we probably want (qualifiers, years more than 5 digits, etc)

@rlskoeser rlskoeser marked this pull request as draft November 3, 2023 20:27
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.71%. Comparing base (ab378da) to head (ff3ea6d).

❗ Current head ff3ea6d differs from pull request most recent head 6221946. Consider uploading reports for the commit 6221946 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #67      +/-   ##
===========================================
+ Coverage    98.65%   98.71%   +0.06%     
===========================================
  Files            4        5       +1     
  Lines          223      234      +11     
===========================================
+ Hits           220      231      +11     
  Misses           3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rlskoeser rlskoeser marked this pull request as ready for review April 19, 2024 17:00
@rlskoeser rlskoeser changed the title Preliminary edtf parsing (levels 0 and 1) with lark Preliminary edtf parsing (levels 0 and some of 1) with lark Apr 19, 2024
@rlskoeser rlskoeser merged commit 33a8d75 into develop Apr 25, 2024
9 checks passed
@rlskoeser rlskoeser deleted the edtf-parsing branch April 25, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant