Move types needed in Dhall.DirectoryTree to own module #2455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@sjakobi: I think it's because the branch lives in a separate repo. The GitHub action probably only runs when people push branches to this repository. Changing |
Collaborator
Author
|
@sjakobi The GHA run over there: https://github.com/mmhat/dhall-haskell/actions |
Gabriella439
added a commit
that referenced
this pull request
Sep 29, 2022
Gabriella439
approved these changes
Sep 29, 2022
Gabriella439
added a commit
that referenced
this pull request
Sep 29, 2022
mmhat
force-pushed
the
2452-fix-windows-build
branch
from
ef96344 to
b9fc167
Compare
In order to fix the Windows builds observed in dhall-lang#2452 we only include the `FromDhall CUid` and `FromDhall CGid` instance only if we are on that platform. Those types are not available there which caused the CI failure. Fixes dhall-lang#2452
It is currently broken; See the discussion of dhall-lang#2452
It is not provided by the unix-compat package.
mmhat
force-pushed
the
2452-fix-windows-build
branch
from
2020ab5 to
ef259d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to fix the Windows builds observed in #2452 we only include the
FromDhall CUidandFromDhall CGidinstance only if we are on that platform. Those types are not available there which caused the CI failure.Fixes #2452