add higher-kinded type support to TH #2506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gabriella439
approved these changes
Apr 13, 2023
locallycompact
pushed a commit
to locallycompact/dhall-haskell
that referenced
this pull request
Apr 26, 2023
locallycompact
pushed a commit
to locallycompact/dhall-haskell
that referenced
this pull request
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses other half of #2475
Overview of changes to logic: rather than immediately parsing the dhall type into a union/single constructor, first recursively peel back any lambdas at the front of the dhall type and collect these in a bound variable list. Then when constructing the nested data type, add two paths for a) higher kinded haskell types (besides Maybe and List) and b) any of these bound variables from the front of the type.
The main gotcha is that this won't work with built-in From/ToDhall derivations as produced by
GenerateOptions(or if this is possible I don't know how to do it). In any case the docs are updated to reflect this.