Skip to content

Disable the tests that use httpbin.org #2533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 3, 2023
Merged

Disable the tests that use httpbin.org #2533

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e64ffb
Disable the tests that use httpbin.org
Gabriella439 Sep 3, 2023
16883b6
Try to fix CI failure on Windows
Gabriella439 Sep 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
submodules: true
- id: setup-haskell-cabal
name: "Setup Haskell environment"
uses: haskell/actions/setup@v1.2.1
uses: haskell/actions/setup@v2.4.6
with:
enable-stack: true
- name: "Cache"
Expand Down
18 changes: 18 additions & 0 deletions dhall/tests/Dhall/Test/Import.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,24 @@ getTests = do
, importDirectory </> "success/unit/asLocation/RemoteChain2A.dhall"
, importDirectory </> "success/unit/asLocation/RemoteChain3A.dhall"
, importDirectory </> "success/unit/asLocation/RemoteChainMissingA.dhall"

-- Skip all tests that reference httpbin.org to avoid clobbering
-- their servers. These should eventually be replaced by tests
-- that depend on an equivalent endpoint on test.dhall-lang.org
-- instead of httpbin.org.
, importDirectory </> "failure/customHeadersUsingBoundVariable.dhall"
, importDirectory </> "failure/originHeadersFromRemote.dhall"
, importDirectory </> "failure/originHeadersFromRemoteENV.dhall"
, importDirectory </> "success/customHeadersA.dhall"
, importDirectory </> "success/noHeaderForwardingA.dhall"
, importDirectory </> "success/success/originHeadersA.dhall"
, importDirectory </> "success/originHeadersENV.dhall"
, importDirectory </> "success/originHeadersImportA.dhall"
, importDirectory </> "success/originHeadersImportENV.dhall"
, importDirectory </> "success/originHeadersImportFromEnvA.dhall"
, importDirectory </> "success/originHeadersImportFromEnvENV.dhall"
, importDirectory </> "success/originHeadersOverrideA.dhall"
, importDirectory </> "success/originHeadersOverrideENV.dhall"
]

successTests <- Test.Util.discover (Turtle.chars <* "A.dhall") successTest (do
Expand Down