Skip to content
This repository has been archived by the owner on Jan 31, 2020. It is now read-only.

Commit creation #21

Open
1 task
dhardy opened this issue Feb 23, 2016 · 1 comment
Open
1 task

Commit creation #21

dhardy opened this issue Feb 23, 2016 · 1 comment

Comments

@dhardy
Copy link
Owner

dhardy commented Feb 23, 2016

We could redesign PartitionState to store a list or map of changes instead of a
parent sum. clone_child() would then reset the list of changes.

This would optimise for few changes to a large set of elements (which is the
intended usage); the current optimises more for many changes to a small set of
elements.

We could support both of these via separate types, plus possibly a third type
which does not support modification. There would be a clone_... method for
each type and a Partition would need to be able to create a commit from each
type which supports modifications.

  • State remembers parent: has to store a Sum (currently 32 bytes)
  • State remembers Vec of changes: 24 bytes (I think)
  • State remembers HashMap of changes: 40 bytes (I think)
  • Code tag #0021
@dhardy dhardy mentioned this issue Feb 23, 2016
1 task
dhardy added a commit that referenced this issue Mar 9, 2016
PartitionState immutable
Implement new statesum with metadata sum
@dhardy
Copy link
Owner Author

dhardy commented Mar 9, 2016

The main part of this was implemented in order to allow metadata of new states to be set in a "correct" way.

The remaining question: should the new MutPartState continue to operate by mutating a set of elements or instead build a set of changes?

@dhardy dhardy added this to the Stable release milestone Apr 12, 2016
@dhardy dhardy modified the milestones: Bonus features, Stable release Jul 27, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant