-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix / suppress JitterRng x86_64-apple-darwin test? #55
Comments
Experiment: which platforms fail? Result: from the platforms we test, only |
It is a bit strange, but I didn't add test to |
I now see it is part of the benchmarks. That is strange! |
Yes, I wonder. It could simply be that The FreeBSD nightly failed too (unknown error). Whatever, we can make do with just one nightly test. |
Workaround #55: don't run nightly tests on darwin
The documentation of jitterentropy say
I will make a PR and see how it goes (can't test because I have not Apple device). |
I would not add a FreeBSD nightly for now. Nightly rustc breaks once in a while because it is not tier 1, I think? |
This CI run failed due to
CoarseTimer
: https://travis-ci.org/dhardy/rand/jobs/303686167I'm a bit surprised that it failed on a common platform. Note that this test is part of the benchmark, which is only run in nightly builds, of which we only have two. Should we add regular tests? Should we simply not test JitterRng because we can't expect it to run on all platforms?
The text was updated successfully, but these errors were encountered: