Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI based on trust #44

Merged
merged 1 commit into from
Nov 11, 2017
Merged

Add CI based on trust #44

merged 1 commit into from
Nov 11, 2017

Conversation

pitdicker
Copy link

@pitdicker pitdicker commented Nov 10, 2017

I have just followed the instructions from trust, but know nothing about CI. Let's see what happens.

@pitdicker
Copy link
Author

Wow, it actually seems to work.

Systems tested:

  • Android
  • iOS
  • OS X (x86 and x86_64)
  • Linux (x86 and x86_64)
  • FreeBSD (x86 and x86_64)
  • NetBSD (x86_64)

Big-endian:

  • Linux (mips and mips64)

Nightly (documentation, benchmarks, i128 feature)

  • Linux (x86_64)
  • OS X (x86_64)

I have commented out the documentation uploading part (not sure where it goes...).
And the deployment parts of trust I did not copy at all.

We had only one endianness problem.

@pitdicker pitdicker changed the title [WIP] Add CI based on trust Add CI based on trust Nov 10, 2017
Copy link
Owner

@dhardy dhardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I guess this is okay for now.

I think the doc-build is for automatic upload to GH-pages, but we're not using that at the moment anyway.

.travis.yml Outdated
env:
global:
# TODO Update this to match the name of your project.
- CRATE_NAME=trust
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be rand? Actually it's probably only for upload and could be removed.

- cargo test --all --features nightly
- cargo test --all --benches
- cargo build --all --no-default-features
- cargo doc --no-deps --features nightly
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we can do without the doc build. It would be nice to have the benchmark test (build test) because I've accidentally broken those a couple of times, but that can only be built on nightly. If you're not sure how just leave a comment somewhere.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I have broken benches the too...

In CI/script.sh I have the tests:

cross build --target $TARGET
cross build --all --no-default-features --target $TARGET --release
cross test --all --target $TARGET

And for nightly only:

cross doc --no-deps --features nightly
cross test --all --features nightly --target $TARGET
cross test --all --benches --target $TARGET

So we shouldn't be missing something big.

@pitdicker
Copy link
Author

Updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants