Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ISAAC performance (take 2) #45

Merged
merged 8 commits into from
Nov 11, 2017
Merged

Improve ISAAC performance (take 2) #45

merged 8 commits into from
Nov 11, 2017

Commits on Nov 11, 2017

  1. Add rand_core::impl::fill_via_u*_chunks

    @pitdicker
    pitdicker committed Nov 11, 2017
    Configuration menu
    Copy the full SHA
    d67864a View commit details
    Browse the repository at this point in the history

  2. Convert ChaCha to use fill_via_u32_chunks 

    This also replaces `core::num::Wrapping` with a few `wrapping_add`'s.
There were about 30 conversions to and from `Wrapping`, while there are only
9 wrapping operations.

Because `fill_via_u32_chunks` expects a `[u32]`, converting away was just
easier.
    @pitdicker
    pitdicker committed Nov 11, 2017
    Configuration menu
    Copy the full SHA
    d7b014c View commit details
    Browse the repository at this point in the history

  3. Fill isaac backwards, and use fill_via_u32_chunks 

    Also uses a different solution to index without bounds checking, to recover a
very little bit of lost performance.
    @pitdicker
    pitdicker committed Nov 11, 2017
    Configuration menu
    Copy the full SHA
    f92a347 View commit details
    Browse the repository at this point in the history

  4. Fill isaac64 backwards, and use fill_via_u32_chunks

    @pitdicker
    pitdicker committed Nov 11, 2017
    Configuration menu
    Copy the full SHA
    707c3e1 View commit details
    Browse the repository at this point in the history

  5. Improve performance of isaac64::next_u32. 

    This does some crazy things with indexing, but is 45% faster. We are no longer
throwing away half of the results.
    @pitdicker
    pitdicker committed Nov 11, 2017
    Configuration menu
    Copy the full SHA
    415ef6f View commit details
    Browse the repository at this point in the history

  6. Remove complex indexing, use a bool.

    @pitdicker
    pitdicker committed Nov 11, 2017
    Configuration menu
    Copy the full SHA
    0bdb1c3 View commit details
    Browse the repository at this point in the history

  7. Add test for alternating between next_u64 and next_u32

    @pitdicker
    pitdicker committed Nov 11, 2017
    Configuration menu
    Copy the full SHA
    5f4bedf View commit details
    Browse the repository at this point in the history

  8. Improve documentation

    @pitdicker
    pitdicker committed Nov 11, 2017
    Configuration menu
    Copy the full SHA
    69d940f View commit details
    Browse the repository at this point in the history