158344830 test: filling DebtOrder #205
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saturnial
reviewed
Jun 14, 2018
| await debtOrder.fill(fillParameters); | ||
| expect(spy).toBeCalled(); | ||
|
|
||
| spy.mockReset(); |
There was a problem hiding this comment.
these should move to afterEach
saturnial
reviewed
Jun 14, 2018
| const spy = jest.spyOn(dharma.order, "fillAsync"); | ||
| // jest#spyOn seems to have issues with mocking async functions by default | ||
| // tslint:disable-next-line | ||
| spy.mockImplementation(async () => {}); |
There was a problem hiding this comment.
why do we need to mock the implementation?
houndci-bot
reviewed
Jun 15, 2018
| description: "when the debt order is open", | ||
| creditorAddress, | ||
| debtOrderParams, | ||
| setUpDebtOrder: (debtOrder: DebtOrder) => {}, |
graemecode
reviewed
Jun 15, 2018
| describe("#create", async () => { | ||
| await testCreate(dharma, DEBT_ORDER_PARAMS_ONE); | ||
| }); | ||
| // describe("#create", async () => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.