Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor code to follow OOP principles #71

Open
dharple opened this issue Mar 1, 2021 · 2 comments
Open

Refactor code to follow OOP principles #71

dharple opened this issue Mar 1, 2021 · 2 comments
Assignees

Comments

@dharple
Copy link
Owner

dharple commented Mar 1, 2021

While it's not currently possible to switch to using classes, structs and associated functions can still be grouped together in a way that makes more sense. The current structure is organic, and hard to follow.

General:

  • Move functions closer to their represented object (file, translation table, sequence, etc).
  • Use typedefs.

Step 1:

  • The filter needs to reference a cleaner by an enum instead of a class reference.
  • The cleaners need to take options specific to their interface, not a generic, all encompassing "options" struct.
@dharple dharple self-assigned this Mar 1, 2021
@dharple
Copy link
Owner Author

dharple commented Mar 1, 2021

Before I can convert the structs to typedefs, I have to stop using chains to link sequences and filters.

@dharple
Copy link
Owner Author

dharple commented Mar 16, 2021

All of the structs have been updated to use typedefs.

Open items:

  • Rename the filter methods that load tables to something like table_load_from_filesystem and table_load_builtin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant