Support for logging out of the local CAS session #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… similar systems. These files are derived from the mod_auth_cas package for EPEL 6
- Added docker container for easy development. - Rewrite documentation with Markdown. - Add some more build files to .gitignore
Previously, there was no way to force the local session to terminate except for the timeout expiring on it's own. This allows the specification of an endpoint that will terminate the user's session, and, optionally, log them out of the CAS service itself. - Updated `getCASService` to require specifying the service URL as either a relative or absolute URL. For the latter, we ensure that it's a URL on the current host/port. - Add `CASLogoutUseReferer` to allow the logout redirect to be pulled from the referer header, off by default. - Moved to using `SetHandler` rather than `CASLogoutHandlerURL`. - Implement a logout handler that trashes the cache file of the user's cookie and redirects them to SSO logout if specified, including a custom redirect URI if specified, or just to a custom redirect URI. - Add `etc` to .gitignore to support the Docker container. - Moved to using `SetHandler` rather than `CASLogoutHandlerURL`. - Removed and ignored autoconf generated files that cause breakages building on some systems. Instead, have users run the more involved incantation. - Added support for Travis autobuilding and deployments to Bintray and Github releases. - Created Dockerfiles for development and RPM building. - Merged in klausdieterkrannich#1, adding a Red Hat spec file to easily build RPMs. Note that the included patch was removed as it doesn't seem to be relevant anymore. - Bumped version to 1.1.1.
|
If the non-functional changes are a bit much, I can likely rip out just the code changes create a PR for those. |
|
We are very close to merging dhawes:v1.1 with jasig:master and probably won't have time to accept this pull request before then. That said, I look forward to reviewing your changes and appreciate the work. When we do merge to jasig:master, it will probably make more sense to make this merge request there so we can continue evaluation and discussion on the official repository. |
|
I noticed that today, I'll close this for now and try making it against mainline once this one is accepted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, there was no way to force the local session to terminate except for the timeout expiring on it's own. This allows the specification of an endpoint that will terminate the user's session, and, optionally, log them out of the CAS service itself.
In addition, to make development and deployment a bit easier, this cleans up some build artifacts, adds a Dockerfile to generate a development container, and includes Travis building and Bintray & Github deployment support.