-
-
Notifications
You must be signed in to change notification settings - Fork 797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: responses without default key #1751
fix: responses without default key #1751
Conversation
@dnalborczyk Do you have some time to check this? It would simplify my codebase, because now I need to add everywhere default response. Also I attached 2 issues that are related to this PR. |
thank you for the PR @DorianMazur ! I'll have a look in the next coming days. hang tight. |
@dnalborczyk Any news? |
+1 @dnalborczyk |
1 similar comment
+1 @dnalborczyk |
@dherault @dnalborczyk I noticed that this package has pull requests that have been pending for long time, including this one which has been waiting for 4 months. If you are seeking for additional maintainers to help manage the project, I would be happy to assist. |
That's great! |
Description
This pull request introduces fixes for two issues in the serverless-offline repository:
Issue #1705 & Issue #1680 : Resolved a TypeError encountered when destructuring properties from an undefined 'chosenResponse' object in HttpServer.js.
Motivation and Context
Fixing Issue #1705 & #1680 enhances the response handling mechanism and also resolves a critical bug that hinders the normal functionality.
How Has This Been Tested?
Tests were conducted by replicating the scenarios described in the issues. Additional e2e tests were added to cover the new scenarios and ensure no regressions in other parts of the code.