fix: return 500 Internal Server Error on python error #1796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DorianMazur
changed the title
dherault
approved these changes
Aug 17, 2024
Thanks! I'd love to see it go to both, as I'm currently still on serverless v3 with most projects. |
|
I'll see if I can squeeze that this week |
|
Sorry for the delay, I'll see that it is merged |
dherault
added a commit
that referenced
this pull request
Aug 30, 2024
fix: return 500 Internal Server Error on python error
|
Sorry but I had to revert your PR because of failing test. Please open a new one if you want it merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Return a 500 Internal Server Error when the Python handler raises an error
Motivation and Context
When (Python) code raises an error, AWS Lambda returns a 500 with a generic JSON response.
With this change the behaviour of Serverless Offline is more inline with AWS Lambda.
How Has This Been Tested?
Added an automated test for Python.
Screenshots (if appropriate):