-
-
Notifications
You must be signed in to change notification settings - Fork 796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for nodejs22.x runtime #1837
Conversation
It is possible to made it for serverless-offline 13 and 14 ? Not only serverless-offline 14 ? |
Currently a blocker for us, looking forward to the patch. |
Correct me if I'm wrong but serverless framework v3 does not support node 22 currently (serverless/serverless#12922), and serverless-offline 13 has a peer dep of serverless v3 |
@bchew No worries with version 3 of serverless: I've been able to publish my lambdas in node22.x on AWS but I can't manage it locally with serverless-offline. |
@throrin19 I wasn't game enough to push without testing yet, so got stuck at not being able to launch locally. Edit: actually, looking again it wasn't a failure, just a warning (on 13.3.4):
|
@alexw23 I understand, I revert the runtime until it is ready here. After test yes the message is a warning but the offline lambda is not executed |
Created a PR to v13 branch: #1838 |
Amazing work, thanks! |
@DorianMazur seems like all the tests are failing due to serverless v4 enforcing logins:
I assume a login is required to set access keys for GitHub Actions CI? #1835 has also the same failures in tests |
Yes, I am waiting for @dherault to respond. We need to find a way to run tests. They are failing because GitHub Secrets are not accessible in PR forks. |
@DorianMazur What should I do? |
@dherault I messaged you elsewhere, but I'll copy it here: If I understand it correctly, then we can enable "Send secrets to workflows from fork pull requests". The SERVERLESS_ACCESS_KEY isn’t a highly sensitive secret. I just created a free account on Serverless and generated this auth key, so there’s nothing to worry about. We can also configure it to always require approval for workflows on PRs- "Require approval for all outside collaborators". |
Is it not possible to just add the ACCESS_KEY to your forked repo for now? At least then we can get this PR through? |
The current version of serverless-offline 14.3.4 does not have support for nodejs22.x. When will you release a new version that supports nodejs22.x? |
@edwinparejas Yes, this weekend. |
Description
Add support for Node.js 22 runtime
Motivation and Context
AWS Lambda now supports Node.js 22:
Related PR in Serverless Framework: serverless/serverless#12916
How Has This Been Tested?
Screenshots (if appropriate):