Skip to content

Commit

Permalink
Fixing b0rken runtimeconfig unit tests.
Browse files Browse the repository at this point in the history
Broken by simultaneous merges of googleapis#2594 and googleapis#2485.
  • Loading branch information
dhermes committed Oct 25, 2016
1 parent 25f4475 commit 7f5ac7a
Showing 1 changed file with 10 additions and 6 deletions.
16 changes: 10 additions & 6 deletions runtimeconfig/unit_tests/test_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -208,13 +208,15 @@ def test_get_variable_w_alternate_client(self):
self.assertEqual(req['path'], '/%s' % (VARIABLE_PATH,))

def test_list_variables_empty(self):
import six

conn = _Connection({})
client = _Client(project=self.PROJECT, connection=conn)
config = self._makeOne(name=self.CONFIG_NAME, client=client)

iterator = config.list_variables()
iterator.update_page()
variables = list(iterator.page)
page = six.next(iterator.pages)
variables = list(page)
token = iterator.next_page_token

self.assertEqual(variables, [])
Expand All @@ -227,6 +229,7 @@ def test_list_variables_empty(self):
self.assertEqual(req['path'], '/%s' % (PATH,))

def test_list_variables_defaults(self):
import six
from google.cloud.runtimeconfig.variable import Variable

VARIABLE_1 = 'variable-one'
Expand All @@ -249,8 +252,8 @@ def test_list_variables_defaults(self):
config = self._makeOne(name=self.CONFIG_NAME, client=client)

iterator = config.list_variables()
iterator.update_page()
variables = list(iterator.page)
page = six.next(iterator.pages)
variables = list(page)
token = iterator.next_page_token

self.assertEqual(len(variables), len(DATA['variables']))
Expand All @@ -269,6 +272,7 @@ def test_list_variables_defaults(self):
self.assertNotIn('filter', req['query_params'])

def test_list_variables_explicit(self):
import six
from google.cloud.runtimeconfig.variable import Variable

VARIABLE_1 = 'variable-one'
Expand All @@ -293,8 +297,8 @@ def test_list_variables_explicit(self):
page_size=3,
page_token=TOKEN,
client=client)
iterator.update_page()
variables = list(iterator.page)
page = six.next(iterator.pages)
variables = list(page)
token = iterator.next_page_token

self.assertEqual(len(variables), len(DATA['variables']))
Expand Down

0 comments on commit 7f5ac7a

Please sign in to comment.