Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updater optimization #133

Open
dhilt opened this issue Jan 30, 2020 · 0 comments
Open

Updater optimization #133

dhilt opened this issue Jan 30, 2020 · 0 comments
Labels
enhancement permanent ignore stale bot

Comments

@dhilt
Copy link
Owner

dhilt commented Jan 30, 2020

Currently Workflow.fix({ updater }) runs through all the items in the Buffer. Could the procedure be optimized? There is a suggestion to convert updater into predicate function or provide breaking callback:

  // predicate
  this.datasource.adapter.fix({
    updater: ({ data }: { data: MyItem }) => {
      if (this.needToUpdate(data)) {
        this.updateItem(data);
        return true;
      }
    }
  });

  // callback
  this.datasource.adapter.fix({
    updater: ({ data }: { data: MyItem }, callback: Function) => {
      if (this.needToUpdate(data)) {
        this.updateItem(data);
        callback();
      }
    }
  });

Source: issue 121

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement permanent ignore stale bot
Projects
None yet
Development

No branches or pull requests

1 participant