Core-Consumer interactions improvements #30
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Define .node-version that can be read by multiple node.js version managers. Using the emerging standard: https://github.com/shadowspawn/node-version-usage * .nvmrc is a superset of .node-version standard. It is safe to `ln -s .node-version .nvmrc`, but not vice versa. * For example, don't use special .nvmrc syntax/features inside .node-version. If strict .node-version syntax is used, then it will work for .nvmrc
* package-lock.json: Updated to lockfileVersion 2 because npm is pinned to version 7. v2 unlocks the ability to do deterministic and reproducible builds. * Upgraded: * @typescript-eslint/eslint-plugin * @typescript-eslint/parser
…se the interface has a generic and defining WorkflowParams with ConstructorParameters causes the generic argument to be lost.
Export worflow params
This was referenced Oct 5, 2021
Merged
dhilt
commented
Oct 5, 2021
| @@ -18,7 +18,7 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| strategy: | |||
| matrix: | |||
| node-version: [12.x] | |||
| node-version: [14.x] | |||
There was a problem hiding this comment.
GitHub said:
This version of npm is compatible with lockfileVersion@1, but package-lock.json was generated for lockfileVersion@2. I'll try to do my best with it!
This should help.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed within seven days if no further activity occurs. If it needs to remain open, add the "permanent" label. |
|
This issue has been automatically closed because it was stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue #29.
List of changes: