fix: refetch loop

dhis2-sre · Jul 3, 2023 · 69dc309 · 69dc309
1 parent ef8d6c3
commit 69dc309
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/components/NewInstance.tsx b/src/components/NewInstance.tsx
@@ -114,7 +114,7 @@ export const NewInstance = () => {
  ))}
  </SingleSelectField>
  <h4 className={styles.subheader}>Stack configuration</h4>
- <StackConfigurator stackName={selectedStack.name} ref={stackConfiguratorRef} disabled={isPosting} />
+ <StackConfigurator name={selectedStack.name} ref={stackConfiguratorRef} disabled={isPosting} />
  {postError && (
  <NoticeBox error title="Save error" className={styles.error}>
  An error occurred while saving the new instance

diff --git a/src/components/StackConfigurator.tsx b/src/components/StackConfigurator.tsx
@@ -1,4 +1,4 @@
-import { Divider, InputField, TextArea, SingleSelectField, SingleSelectOption } from '@dhis2/ui'
+import { Divider, InputField, SingleSelectField, SingleSelectOption, TextArea } from '@dhis2/ui'
 import { getStack } from '../api/stacks'
 import { Stack } from '../types/stack'
 import { useApi } from '../api/useApi'
@@ -53,7 +53,7 @@ const ttlMap = new Map<string, number>([
  ['1 month', 60 * 60 * 24 * 7 * 4],
 ])
 
-export const StackConfigurator = forwardRef(function StackConfigurator({ stackName, disabled }: { stackName: string; disabled: boolean }, ref) {
+export const StackConfigurator = forwardRef(function StackConfigurator({ name: stackName, disabled }: { name: string; disabled: boolean }, ref) {
  const [name, setName] = useState('')
  const [description, setDescription] = useState('')
  const [requiredStackParameters, setRequiredStackParameters] = useState({})
@@ -81,10 +81,10 @@ export const StackConfigurator = forwardRef(function StackConfigurator({ stackNa
  )
 
  useEffect(() => {
- if (!isFetching && stack && stack.name !== name) {
+ if (!isFetching && stack && stack.name !== stackName) {
  refetch()
  }
- }, [name, refetch, stack, isFetching])
+ }, [stackName, refetch, stack, isFetching])
 
  useEffect(() => {
  if (stack) {