fix: remove unused export for useLocale (and update tests) #826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kabaros
approved these changes
Jan 25, 2024
dhis2-bot
added a commit
that referenced
this pull request
Jan 25, 2024
# [10.5.0-alpha.2](v10.5.0-alpha.1...v10.5.0-alpha.2) (2024-01-25) ### Bug Fixes * remove unused export for useLocale (and update tests) ([#826](#826)) ([d4262e1](d4262e1))
|
🎉 This PR is included in version 10.5.0-alpha.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
kabaros
pushed a commit
that referenced
this pull request
Feb 16, 2024
* test: update tests to target useCurrentUserLocale * fix: remove unused export on useLocale
kabaros
added a commit
that referenced
this pull request
Feb 19, 2024
* feat: `dir` config for language directions and other i18n fixes [DHIS2-16480] (#825) * feat: change text direction based on locale * feat: add direction config to d2.config * refactor: split up handleLocale * refactor: rename function; add dir default to adapter * fix: remove direction from d2.config defaults in CLI * refactor: parse locale to Intl.Locale object * refactor: better i18nLocale logic * fix: moment locale formatting & add fallbacks * refactor: fn rename * refactor: move locale utils to a new file * test: set up test file for useLocale.test * fix: skip logic for en and en-US * test: add first useLocale tests * test: userSettings cases * test: add document direction tests * fix: handle nonstandard configDirections * feat: set document `lang` attribute * fix: remove unused export for useLocale (and update tests) (#826) * test: update tests to target useCurrentUserLocale * fix: remove unused export on useLocale --------- Co-authored-by: Kai Vandivier <49666798+KaiVandivier@users.noreply.github.com>
dhis2-bot
added a commit
that referenced
this pull request
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #825