Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): upgrade app-runtime and ui #895

Merged
merged 4 commits into from
Dec 6, 2024
+1,091 −1,359
Merged

fix(deps): upgrade app-runtime and ui #895

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7309dfb
fix(deps): upgrade app-runtime and ui
KaiVandivier Dec 4, 2024
fb484cd
fix(deps): add @testing-library/dom to dev deps
KaiVandivier Dec 5, 2024
6009397
docs: mention @testing-library/dom requirement
KaiVandivier Dec 5, 2024
da386a3
fix(deps): upgrade UI to remove unnecessary testing-library prod dep
KaiVandivier Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion adapter/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
"devDependencies": {
"@dhis2/cli-app-scripts": "12.0.0-alpha.25",
"@testing-library/react": "^16.0.1",
"@testing-library/dom": "^10.4.0",
"enzyme": "^3.11.0",
"enzyme-adapter-react-16": "^1.15.5",
"react": "^18",
Expand All @@ -39,7 +40,7 @@
"peerDependencies": {
"@dhis2/app-runtime": "^3.11.1",
"@dhis2/d2-i18n": "^1",
"@dhis2/ui": ">=9.11.7",
"@dhis2/ui": ">=10.1.7",
"classnames": "^2",
"moment": "^2",
"prop-types": "^15",
Expand Down
4 changes: 4 additions & 0 deletions docs/migration/v12.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,10 @@ Testing-library supports React 18 since v13, so the first step is to upgrade tha

Examples come from the migration for the Aggregate Data Entry app; you can check out the PR [here](https://github.com/dhis2/aggregate-data-entry-app/pull/396) for more examples in context.

##### `@testing-library/dom` is now a required peer dependency

Since `@testing-library/react` v16, `@testing-library/dom` is now [required to be installed as a dev dependency](https://github.com/testing-library/react-testing-library/releases/tag/v16.0.0) alongside `@testing-library/react`.

##### `userEvent`

`userEvent` is async now in `@testing-library/user-event`. Check the [release notes](https://github.com/testing-library/user-event/releases/tag/v14.0.0) for an idea of the improvements and new API. In practice, this means mostly that you'd need to add an `await` for `userEvent` interactions like `userEvent.click()`.
Expand Down
4 changes: 2 additions & 2 deletions shell/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@
},
"dependencies": {
"@dhis2/app-adapter": "12.0.0-alpha.25",
"@dhis2/app-runtime": "^3.11.1",
"@dhis2/app-runtime": "^3.12.0",
"@dhis2/d2-i18n": "^1.1.1",
"@dhis2/pwa": "12.0.0-alpha.25",
"@dhis2/ui": "^9.11.7",
"@dhis2/ui": "^10.1.7",
"classnames": "^2.2.6",
"moment": "^2.29.1",
"post-robot": "^10.0.46",
Expand Down
Loading
Loading