Skip to content

Commit

Permalink
fix: make the messages more meaningful (#25)
Browse files Browse the repository at this point in the history
* fix: make the messages more meaningful

* fix: update no files message

* fix: proper message when check has no files to check

* fix: update messages

* fix: drop redundant msg
  • Loading branch information
varl authored Mar 7, 2019
1 parent ece8c53 commit d2ae8af
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 7 deletions.
9 changes: 7 additions & 2 deletions src/cmds/js_cmds/apply.js
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,15 @@ exports.handler = argv => {
log.debug('rootDir?', root_dir)
log.debug('codeFiles?', codeFiles)

const prettyFiles = apply_fmt(jsFiles(codeFiles))
const js = jsFiles(codeFiles)
const prettyFiles = apply_fmt(js)

if (prettyFiles.length === 0) {
log.info('No files to style.')
if (js.length > 0) {
log.info(`${js.length} file(s) reformatted.`)
} else {
log.info('No files to format.')
}
}

configure(root_dir)
Expand Down
14 changes: 10 additions & 4 deletions src/cmds/js_cmds/check.js
Original file line number Diff line number Diff line change
Expand Up @@ -35,19 +35,25 @@ exports.handler = argv => {
log.debug('rootDir?', root_dir)
log.debug('codeFiles?', codeFiles)

const prettyFiles = check_fmt(jsFiles(codeFiles))
const js = jsFiles(codeFiles)
const prettyFiles = check_fmt(js)

const success = prettyFiles.length > 0

if (success) {
log.info(`Files to style:`)
prettyFiles.forEach(f =>
log.print(`\t${path.relative(process.cwd(), f)}`)
log.print(`${path.relative(process.cwd(), f)}`)
)
log.error('One or more files failed the style check')
log.print('')
log.error(`${prettyFiles.length} file(s) failed the style check`)
process.exit(1)
} else {
log.info('No files to style.')
if (js.length > 0) {
log.info(`${js.length} file(s) passed the style check.`)
} else {
log.info('No files to check.')
}
process.exit(0)
}
}
1 change: 0 additions & 1 deletion src/prettier.js
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,6 @@ exports.apply_fmt = function apply_prettier(files) {
? log.debug('file written to disk')
: log.debug('file write FAILED')

log.info(`Reformatted: ${file}`)
pretty_files.push(file)
} catch (error) {
log.error('Formatting failed.', file, error)
Expand Down

0 comments on commit d2ae8af

Please sign in to comment.