fix: avoid unnecessary rerenders using stable default prop references…

… (partial)
dhis2 · Sep 25, 2024 · 1210dff · 1210dff
1 parent 371fdb0
commit 1210dff
Show file tree

Hide file tree

Showing 6 changed files with 23 additions and 18 deletions.
diff --git a/components/button/src/split-button/split-button.js b/components/button/src/split-button/split-button.js
@@ -82,7 +82,6 @@ class SplitButton extends Component {
 
  const arrow = open ? <IconChevronUp16 /> : <IconChevronDown16 />
 
- console.log(dataTest)
  return (
  <div ref={this.anchorRef} data-test={dataTest}>
  <Button

diff --git a/components/file-input/src/file-input-field-with-list/file-input-field-with-list.js b/components/file-input/src/file-input-field-with-list/file-input-field-with-list.js
@@ -70,7 +70,7 @@ class FileInputFieldWithList extends Component {
  render() {
  const {
  accept,
- buttonLabel = () => i18n.t('Upload a file'),
+ buttonLabel = FileInputFieldWithList.defaultProps.buttonLabel,
  className,
  dataTest = 'dhis2-uiwidgets-fileinputfieldwithlist',
  disabled,
@@ -85,8 +85,8 @@ class FileInputFieldWithList extends Component {
  onBlur,
  onFocus,
  onKeyDown,
- placeholder = () => i18n.t('No file uploaded yet'),
- removeText = () => i18n.t('Remove'),
+ placeholder = FileInputFieldWithList.defaultProps.placeholder,
+ removeText = FileInputFieldWithList.defaultProps.removeText,
  required,
  small,
  tabIndex,

diff --git a/components/file-input/src/file-input-field/file-input-field.js b/components/file-input/src/file-input-field/file-input-field.js
@@ -16,9 +16,11 @@ const translate = (prop, interpolationObject) => {
  return prop
 }
 
+const defaultButtonLabel = () => i18n.t('Upload a file')
+const defaultPlaceholder = () => i18n.t('No file uploaded yet')
 const FileInputField = ({
  accept = '*',
- buttonLabel = () => i18n.t('Upload a file'),
+ buttonLabel = defaultButtonLabel,
  children,
  className,
  dataTest = 'dhis2-uiwidgets-fileinputfield',
@@ -34,7 +36,7 @@ const FileInputField = ({
  onChange,
  onFocus,
  onKeyDown,
- placeholder = () => i18n.t('No file uploaded yet'),
+ placeholder = defaultPlaceholder,
  required,
  small,
  tabIndex,

diff --git a/components/sharing-dialog/src/sharing-dialog.js b/components/sharing-dialog/src/sharing-dialog.js
@@ -38,19 +38,21 @@ const mutation = {
  data: ({ data }) => data,
 }
 
+const emptyFunction = () => {}
+const defaultInitialSharingSettings = {
+ name: '',
+ allowPublic: true,
+ public: ACCESS_NONE,
+ groups: {},
+ users: {},
+}
 export const SharingDialog = ({
  id,
  type,
- onClose = () => {},
- onError = () => {},
- onSave = () => {},
- initialSharingSettings = {
- name: '',
- allowPublic: true,
- public: ACCESS_NONE,
- groups: {},
- users: {},
- },
+ onClose = emptyFunction,
+ onError = emptyFunction,
+ onSave = emptyFunction,
+ initialSharingSettings = defaultInitialSharingSettings,
  dataTest = 'dhis2-uicore-sharingdialog',
 }) => {
  const { show: showError } = useAlert((error) => error, { critical: true })

diff --git a/components/table/src/stacked-table/stacked-table-cell.js b/components/table/src/stacked-table/stacked-table-cell.js
@@ -3,13 +3,14 @@ import PropTypes from 'prop-types'
 import React from 'react'
 import { ContentWithTitle } from './content-with-title.js'
 
+const defaultHeaderLabels = []
 export const StackedTableCell = ({
  children,
  className,
  colSpan,
  column,
  dataTest = 'dhis2-uicore-stackedtablecell',
- headerLabels = [],
+ headerLabels = defaultHeaderLabels,
  hideTitle,
  rowSpan,
  title,

diff --git a/components/transfer/src/transfer.js b/components/transfer/src/transfer.js
@@ -33,6 +33,7 @@ import {
 import { TransferOption } from './transfer-option.js'
 
 const identity = (value) => value
+const defaultSelected = []
 
 export const Transfer = ({
  options,
@@ -70,7 +71,7 @@ export const Transfer = ({
  rightHeader,
  searchTerm,
  searchTermPicked,
- selected = [],
+ selected = defaultSelected,
  selectedEmptyComponent,
  selectedWidth = '320px',
  sourceEmptyPlaceholder,