chore(release): promote alpha to master #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The available options are different depending on the sharing target and when adding a new user/group.
Implement latest design with ui table components.
These are controlled by the allowExternalAccess/allowPublicAccess. Use ui table components.
This only work for the metadata sharing settings for the moment. It will change when we add support for the data sharing settings.
The sharing settings are fetched when the dialog opens if type/id are available (otherwise the dialog opens with the defaults). Add, update and delete are all synced to the server right away (no Save button).
Show the disabled option and a dialog with user and group accesses.
The information presented is not data that requires tabular display, more like a simple list of selections formatted to align the selects. This should simplify the implementation of the design, especially for implementing the scrolling of the list, while the rest stays fixed.
If the access string for a user/group contained data access settings (aka the 2nd "rw" part in the string) the internal conversion to access constants was returning the default value for publicAccess, which is ACCESS_NONE. This was causing a crash because the dropdown select for user/group does not have the None option. The parsing now uses a regex to only match the correct part of the access string for metadata sharing settings.
And refetch sharing data after a mutate error. This is needed to avoid an out of sync UI, where the settings don't match what's stored server side.
* fix: stop importing from index files * chore(yarn): update yarn.lock * fix(sharing-dialog): stop importing from @dhis2/ui Co-authored-by: ismay <ismay@ismaywolff.nl>
feat: add DHIS2 Sharing Dialog (TECH-274)
# [6.18.0-alpha.1](v6.17.0...v6.18.0-alpha.1) (2021-08-24) ### Bug Fixes * add remove for user/groups ([c2149d9](c2149d9)) * add stories for dashboard cascading sharing ([e4251fe](e4251fe)) * fix crash when an access string contains data settings ([f9ca3e5](f9ca3e5)) * fix i18n string interpolation ([752b641](752b641)) * fix i18n.t usage ([bf02805](bf02805)) * fix icons while waiting for ui-icons to be released ([bcf4c22](bcf4c22)) * fix import ([da9f35e](da9f35e)) * fix imports ([725b6f9](725b6f9)) * fix imports after merging alpha ([91f6737](91f6737)) * fix prop types ([374ca57](374ca57)) * fix prop types ([a00b1ea](a00b1ea)) * fix wrong boolean default for view and edit access ([919a287](919a287)) * implement disabled access select (external/public) ([4938603](4938603)) * implement latest design ([f3f5040](f3f5040)) * make clear the type of access as per latest design ([1b0ada7](1b0ada7)) * minor text correction ([9d91931](9d91931)) * pass label for the search input ([2d8ceb8](2d8ceb8)) * prevent access-before-initialisation storybook errors ([#414](#414)) ([da68680](da68680)) * use fixed version for [@dhis2-ui](https://github.com/dhis2-ui) dependencies ([6d89ba4](6d89ba4)) * use the callback format for error handling ([15550cc](15550cc)) ### Features * Add DHIS2 Sharing Dialog ([758bb10](758bb10)) * implement cascade sharing for dashboard TECH-274 ([b1f7fcd](b1f7fcd)) * implement cascading sharing for dashboards ([efff245](efff245)) * search as you type for user/groups ([5fd447c](5fd447c))
# [6.19.0-alpha.1](v6.18.0...v6.19.0-alpha.1) (2021-08-24) ### Bug Fixes * **release:** trigger release ([adbca7e](adbca7e)) * add remove for user/groups ([c2149d9](c2149d9)) * add stories for dashboard cascading sharing ([e4251fe](e4251fe)) * fix crash when an access string contains data settings ([f9ca3e5](f9ca3e5)) * fix i18n string interpolation ([752b641](752b641)) * fix i18n.t usage ([bf02805](bf02805)) * fix icons while waiting for ui-icons to be released ([bcf4c22](bcf4c22)) * fix import ([da9f35e](da9f35e)) * fix imports ([725b6f9](725b6f9)) * fix imports after merging alpha ([91f6737](91f6737)) * fix prop types ([374ca57](374ca57)) * fix prop types ([a00b1ea](a00b1ea)) * fix wrong boolean default for view and edit access ([919a287](919a287)) * implement disabled access select (external/public) ([4938603](4938603)) * implement latest design ([f3f5040](f3f5040)) * make clear the type of access as per latest design ([1b0ada7](1b0ada7)) * minor text correction ([9d91931](9d91931)) * pass label for the search input ([2d8ceb8](2d8ceb8)) * prevent access-before-initialisation storybook errors ([#414](#414)) ([da68680](da68680)) * use fixed version for [@dhis2-ui](https://github.com/dhis2-ui) dependencies ([6d89ba4](6d89ba4)) * use the callback format for error handling ([15550cc](15550cc)) ### Features * Add DHIS2 Sharing Dialog ([758bb10](758bb10)) * implement cascade sharing for dashboard TECH-274 ([b1f7fcd](b1f7fcd)) * implement cascading sharing for dashboards ([efff245](efff245)) * search as you type for user/groups ([5fd447c](5fd447c))
chore: update alpha with master
# [6.20.0-alpha.1](v6.19.1...v6.20.0-alpha.1) (2021-08-31) ### Bug Fixes * **release:** trigger release ([adbca7e](adbca7e)) * add remove for user/groups ([c2149d9](c2149d9)) * add stories for dashboard cascading sharing ([e4251fe](e4251fe)) * fix crash when an access string contains data settings ([f9ca3e5](f9ca3e5)) * fix i18n string interpolation ([752b641](752b641)) * fix i18n.t usage ([bf02805](bf02805)) * fix icons while waiting for ui-icons to be released ([bcf4c22](bcf4c22)) * fix import ([da9f35e](da9f35e)) * fix imports ([725b6f9](725b6f9)) * fix imports after merging alpha ([91f6737](91f6737)) * fix prop types ([374ca57](374ca57)) * fix prop types ([a00b1ea](a00b1ea)) * fix wrong boolean default for view and edit access ([919a287](919a287)) * implement disabled access select (external/public) ([4938603](4938603)) * implement latest design ([f3f5040](f3f5040)) * make clear the type of access as per latest design ([1b0ada7](1b0ada7)) * minor text correction ([9d91931](9d91931)) * pass label for the search input ([2d8ceb8](2d8ceb8)) * prevent access-before-initialisation storybook errors ([#414](#414)) ([da68680](da68680)) * use fixed version for [@dhis2-ui](https://github.com/dhis2-ui) dependencies ([6d89ba4](6d89ba4)) * use the callback format for error handling ([15550cc](15550cc)) ### Features * Add DHIS2 Sharing Dialog ([758bb10](758bb10)) * implement cascade sharing for dashboard TECH-274 ([b1f7fcd](b1f7fcd)) * implement cascading sharing for dashboards ([efff245](efff245)) * search as you type for user/groups ([5fd447c](5fd447c))
fix(sharing-dialog): cascade sharing texts
# [6.20.0-alpha.2](v6.20.0-alpha.1...v6.20.0-alpha.2) (2021-08-31) ### Bug Fixes * fix info and explanation strings and use pluralisation ([295836a](295836a))
test(sharing-dialog): use mount over shallow
fix: offline mode, form interaction is disabled
|
🚀 Deployed on https://pr-723--dhis2-ui.netlify.app |
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
# [6.20.0-alpha.3](v6.20.0-alpha.2...v6.20.0-alpha.3) (2021-08-31) ### Features * offline mode, form interaction is disabled ([0bc3d3b](0bc3d3b))
edoardo
approved these changes
Aug 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.