Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: disable verify email button #1454

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix: disable verify email button #1454

wants to merge 4 commits into from

Conversation

Chisomchima
Copy link
Member

@Chisomchima Chisomchima commented Dec 11, 2024 •
edited
Loading

this PR attempts to fix this comment for the verify email button ticket

@dhis2-bot
Copy link
Contributor

dhis2-bot commented Dec 11, 2024 •
edited
Loading

🚀 Deployed on https://pr-1454--dhis2-user-profile.netlify.app

@dhis2-bot dhis2-bot temporarily deployed to netlify December 11, 2024 13:58 Inactive
@Chisomchima Chisomchima requested a review from tomzemp December 11, 2024 14:04
@dhis2-bot dhis2-bot temporarily deployed to netlify December 11, 2024 14:04 Inactive
tomzemp
tomzemp reviewed Dec 11, 2024
View reviewed changes
Copy link
Member

@tomzemp tomzemp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I think we should use consistent RegEx

src/layout/VerifyEmail.component.js Outdated Show resolved Hide resolved
@Chisomchima Chisomchima requested a review from tomzemp December 12, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomzemp tomzemp Awaiting requested review from tomzemp

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Chisomchima @dhis2-bot @tomzemp