Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cors policy updated #44

Merged
merged 2 commits into from
Aug 2, 2024
Merged

fix: cors policy updated #44

merged 2 commits into from
Aug 2, 2024

Conversation

RCCodeBase
Copy link
Contributor

No description provided.

@RCCodeBase RCCodeBase requested review from prashant4dev and Vikastc and removed request for prashant4dev August 1, 2024 17:17
Vikastc
Vikastc requested changes Aug 1, 2024
View reviewed changes
Copy link
Collaborator

@Vikastc Vikastc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the cors part of code in a separate file server.ts , this will make the code clean
refer hashmark-studio if you have any doubts

@RCCodeBase RCCodeBase requested a review from Vikastc August 1, 2024 18:24
@prashant4dev prashant4dev merged commit bc07b3f into main Aug 2, 2024
1 check passed
@prashant4dev prashant4dev deleted the corspolicyupdated branch August 2, 2024 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prashant4dev prashant4dev prashant4dev approved these changes

@Vikastc Vikastc Awaiting requested review from Vikastc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RCCodeBase @prashant4dev @Vikastc