Backport of JuliaLang#8725 Fix so @edit works on windows with the d…

…efault editor + line number is printed to the user when it is not passed to the editor.

base/interactiveutil.jl

@@ -24,6 +24,7 @@ function edit(file::String, line::Integer)
         f = find_source_file(file)
         f != nothing && (file = f)
     end
+    no_line_msg = "Unknown editor: no line number information passed.\nThe method is defined at line $line."
     if beginswith(edname, "emacs")
         spawn(`$edpath +$line $file`)
     elseif edname == "vim"
@@ -33,15 +34,18 @@ function edit(file::String, line::Integer)
     elseif beginswith(edname, "subl")
         spawn(`$(shell_split(edpath)) $file:$line`)
     elseif OS_NAME == :Windows && (edname == "start" || edname == "open")
-        spawn(`start /b $file`)
+        spawn(`cmd /c start /b $file`)
+        println(no_line_msg)
     elseif OS_NAME == :Darwin && (edname == "start" || edname == "open")
         spawn(`open -t $file`)
+        println(no_line_msg)
     elseif edname == "kate"
         spawn(`$edpath $file -l $line`)
     elseif edname == "nano"
         run(`$edpath +$line $file`)
     else
         run(`$(shell_split(edpath)) $file`)
+        println(no_line_msg)
     end
     nothing
 end

base/loading.jl

@@ -28,7 +28,7 @@ function find_source_file(file)
     (isabspath(file) || isfile(file)) && return file
     file2 = find_in_path(file)
     file2 != nothing && return file2
-    file2 = "$JULIA_HOME/../share/julia/base/$file"
+    file2 = joinpath(JULIA_HOME, DATAROOTDIR, "julia", "base", file)
     isfile(file2) ? file2 : nothing
 end