Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Guava as a compile dependency #236

Closed
agentgt opened this issue Aug 4, 2021 · 1 comment
Closed

Remove Guava as a compile dependency #236

agentgt opened this issue Aug 4, 2021 · 1 comment
Milestone
1.7.0

Comments

@agentgt
Copy link

agentgt commented Aug 4, 2021

Guava appears to be only used for test code

https://github.com/dhorions/boxable/search?q=google

Yet both the POM (and gradle) has it declared as

<scope>compile</scope>

It should be:

<scope>test</scope>
agentgt added a commit to snaphop/boxable that referenced this issue Aug 4, 2021
@agentgt
Fix issue dhorions#236 make guava test dep
5313bce
@agentgt agentgt mentioned this issue Aug 4, 2021
Closed
@johnmanko johnmanko mentioned this issue Nov 7, 2021
Closed
This was referenced Dec 15, 2021
Closed
Open
johnmanko added a commit that referenced this issue Jun 5, 2022
@johnmanko
fix: #233, #236, #239, #241, #246 and update all other dependencies
943e453
@johnmanko
Copy link
Collaborator

Fixed with 943e453

@johnmanko johnmanko added this to the 1.7.0 milestone Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.7.0
Development

No branches or pull requests
2 participants
@agentgt @johnmanko