Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to namespace Scorekeeper objects #2

Open
dhosterman opened this issue Sep 29, 2016 · 0 comments
Open

Add ability to namespace Scorekeeper objects #2

dhosterman opened this issue Sep 29, 2016 · 0 comments
Assignees
@dhosterman
Labels
enhancement
Milestone
v0.1.1

Comments

@dhosterman
Copy link
Owner

Currently, a score is stored persistently using the Scorekeeper subclass's name, but this could lead to a collision if two different projects were sharing the same environment and had Scorekeepers with the same class name.

An example:

Project A

class MyScoreKeeper(Scorekeeper):
     namespace = project_a

Project B

class MyScoreKeeper(Scorekeeper):
    namespace = project_b
@dhosterman dhosterman added this to the v0.1.1 milestone Sep 29, 2016
@dhosterman dhosterman self-assigned this Sep 29, 2016
dhosterman pushed a commit that referenced this issue Sep 29, 2016
Allow namespaces for scorekeepers
224550c 
Add a new attribute "namespace" on the Scorekeeper object which
forces a scorekeeper object to namespace its own name in the shared
data store.

Also, change _seconds_since_last_score to a property.

Closes #2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dhosterman dhosterman

Labels
enhancement
Projects
None yet
Milestone
v0.1.1
Development

No branches or pull requests
1 participant
@dhosterman