Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

question: plan or thought on upgrading to latest semantic-release version #103

Closed
Badisi opened this issue Apr 2, 2022 · 7 comments · Fixed by #123
Closed

question: plan or thought on upgrading to latest semantic-release version #103

Badisi opened this issue Apr 2, 2022 · 7 comments · Fixed by #123
Labels

Comments

@Badisi
Copy link
Contributor

Badisi commented Apr 2, 2022

Currently this package is using : "semantic-release": "^17.4.7" whereas the latest is 19.0.2.

I've had an issue with semantic-release (#2407) that might be fixed one day (hopefully ^^).
And if so, I was wondering what's the current plan or thought for MSR to upgrade to the latest SR version ?

Thanks!

@antongolub
Copy link
Collaborator

antongolub commented Apr 2, 2022

Migration to semrel v19 is a reasonable change, no doubts. I see several options:

  1. Declare semrel as a peer dependency (breaking change, requires manual install)
  2. Update semrel to v19 (breaking change, requires node v14+)
  3. Install semrel on-fly (complex)
  4. Install both v17 and v19 (aliases + bundled deps?, complex)

Anyway, I think we should configure v2 branch to release only for patches and vulns fixes to support our users who still need old nodejs versions for some reasons.

@Badisi
Copy link
Contributor Author

Badisi commented Apr 2, 2022

I would go with 2. and release a v3 with semrel v19 as a dep and node engine >=16 || ^14.17 to follow semrel.

@janpe
Copy link

janpe commented Aug 24, 2022

Hello @antongolub! Do you see one of these options happening sometime soon? There are currently bunch of vulnerabilities in the dependencies.

Tried something in this pull #122 request but not quite sure how to deal with the error in the CI job.

@antongolub
Copy link
Collaborator

There's an issue with one test, which seems related to npm changes: everything is fine in Node16 / npm 8.5.0 and fails in Node 18.8.0 / npm 8.18.0. I'm afraid I have not enough time to figure out what exaclty went wrong, so I just disabled the test case.

@antongolub
Copy link
Collaborator

🎉 This issue has been resolved in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@janpe
Copy link

janpe commented Aug 26, 2022

Awesome, thanks! 👏

@Badisi
Copy link
Contributor Author

Badisi commented Aug 26, 2022

@antongolub, tests are fixed in #124 😉

@janpe, thanks for helping releasing this feature! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants