fix(lib): package json files were being minified by plugin creator #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the package file is read / a written when the inline plugin is used. By default json strigify doesn't not have any formatting. This results in the package file effectively beign minified. This change introduces simple formatting w/ a 2 space indent Semver: patch
esatterwhite
force-pushed
the
esatterwhite/json-format
branch
from
fabdeaa
to
9d86d7b
Compare
|
@dhoulb have a look |
|
Hey, @esatterwhite The idea is accepted, but this patch needs to be slightly modified. |
|
@dhoulb Could you enable squash commits? |
|
🎉 This issue has been resolved in version 2.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
@antongolub Enabled 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the package file is read / a written when the inline plugin is used.
By default json strigify doesn't not have any formatting. This results
in the package file effectively beign minified. This change introduces
simple formatting w/ a 2 space indent
Semver: patch