WIP: Remove only local sources #163
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 16, 2020
|
Could you add some more tests please? Also I am keen to keep the code as robust as possible. If the set of valid source types evolves over time, then a future source type might be misclassified as ignorable or not. Can you be specific in the code as to how all source types are handled and fail if an unexpected source type is found? |
|
Absolutely. Will do. |
|
Am mulling over a good way to do the tests... I can redirect crates.io to the crates.io ending in .git in a test but proving that it was any different .... ah maybe I could peek into the generated lock file. Bingo that's what I was looking for. |
|
FYI cargo vendor calls this option --respect-source-config |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A tidier way to remove any local sources before trying to vendor.
(If you're ok with the idea give me a thumbs up and I'll write some tests to cover it.)