Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recognise year field for ogg files when present #105

Merged
merged 2 commits into from
Apr 13, 2024

Conversation

yabobay
Copy link
Contributor

@yabobay yabobay commented Mar 9, 2024

Pretty much most of my music library is made up of ogg vorbis files with a Year field and no Date field. Some have both. This is cause some music players will recognize date and some will recognize year. So i don't know if it's part of any standard but i think it'd make sense to account for it here.

Copy link
Owner

@dhowden dhowden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Thanks for the change!

Just a small backwards-compat change, want to make sure that we don't alter existing behaviour where both a date and year field are present.

vorbis.go Outdated Show resolved Hide resolved
@yabobay
Copy link
Contributor Author

yabobay commented Apr 13, 2024

Done!

@dhowden dhowden merged commit dc579f5 into dhowden:master Apr 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants