Minor fixes #200

friebel · 2022-09-25T07:57:11Z

Connection logging after applying these changes:

> rshell --port /dev/cu.usbserial-01EDB820
Connecting to /dev/cu.usbserial-01EDB820 (buffer-size 32) ...
Trying to connect to REPL ... connected
Retrieving sysname ... esp32
Testing if ubinascii.unhexlify exists ... Y
Retrieving root directories ... /testdir/
Setting time ... Sep 25, 2022 09:45:09
Evaluating board_name ... pyboard
Retrieving time epoch ... Jan 01, 2000
Welcome to rshell. Use Control-D (or the exit command) to exit rshell.

Buffer size is not logged twice
All operation ... result messages follow the same format
Root directories list only includes directories, no files

The same information is logged in the called functions, so even uncommenting the debug prints would not add value.

The buffer size is an implementation detail that should just work out of the box and does not add value to the average user. Only print it in debug mode.

Most log messages follow the same format: Operation ... result Modify the two message accordingly that do not follow that format yet.

friebel added 4 commits September 25, 2022 09:51

Remove commented debug prints

7895246

The same information is logged in the called functions, so even uncommenting the debug prints would not add value.

Print buffer size only in debug mode

f75c85f

The buffer size is an implementation detail that should just work out of the box and does not add value to the average user. Only print it in debug mode.

Harmonize connection log messages

9d0c799

Most log messages follow the same format: Operation ... result Modify the two message accordingly that do not follow that format yet.

Only add directories to root dir list

dd06a39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Minor fixes #200

Minor fixes #200

friebel commented Sep 25, 2022

Minor fixes #200

Are you sure you want to change the base?

Minor fixes #200

Conversation

friebel commented Sep 25, 2022