Add threshold for file validations #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, can you open an issue describing what you're trying to do here so we can discuss it? Thanks! |
haritha-ravi
changed the title
di
reviewed
Sep 6, 2023
di
reviewed
Sep 6, 2023
|
Hi @di , I am wondering if there is anything else expected from my side to wrap one up. |
haritha-ravi
force-pushed
the
add_file_error_threshold
branch
from
0902782
to
bd21703
Compare
haritha-ravi
force-pushed
the
add_file_error_threshold
branch
from
760e965
to
9894e15
Compare
|
Closing and re-opening to trigger CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In certain use cases, it becomes unnecessary to continue validating a file if the
fail_countreaches a high number. So this PR aims to optionally stop validating a file if thefail_countreaches a certain threshold.I will also reference the issue here for further context: #90
PS: I am not an expert programmer so please free to suggest corrections in the code and even provide other ideas.
Fixes #90.