-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swimunit 0.2.0.261 initium #55
base: master
Are you sure you want to change the base?
Swimunit 0.2.0.261 initium #55
Conversation
Hi @wherkendell, this is very cool indeed! However, I think there was some misunderstanding. I do not think you should add your entire swimunit plotting library to |
I agree, the dot-matrix stuff would be a nice addition to |
@@ -0,0 +1,843 @@ | |||
{-# LANGUAGE NoMonomorphismRestriction #-} | |||
|
|||
module Diagrams.Swimunit.Dotmatrix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would Diagrams.TwoD.DotMatrix
be more consistent with other modules names?
Also remember to add this to diagrams-contrib.cabal
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Chris,
concerning the TwoD package I can not tell. But personally I would like
to keep Dotmatrix as the emphasis is neither on dot nor on matrix, its
the combination of both and therefore the two nouns should not be
separated by a Camel.
But: If community naming rules are different I will comply to these.
Regards
Wolfram
On 18.09.2015 20:13, Chris wrote:
In src/Diagrams/Swimunit/Dotmatrix.hs
#55 (comment):@@ -0,0 +1,843 @@
+{-# LANGUAGE NoMonomorphismRestriction #-}
+
+module Diagrams.Swimunit.DotmatrixWould |Diagrams.TwoD.DotMatrix| be more consistent with other modules
names?Also remember to add this to |diagrams-contrib.cabal|.
—
Reply to this email directly or view it on GitHub
https://github.com/diagrams/diagrams-contrib/pull/55/files#r39884396.
Hi Chris, I really would love to have the plotting library in an own package! But Dotmatrix can render texts under any circumstances it might be a good On 18.09.2015 20:11, Chris wrote:
|
Everyone can access Dotmatrix when it's on |
Hi Brent, Thank you very much. You are right. Obviously no one can now, that Summarizing: That's fine for me. Thanks for support. Regards On 18.09.2015 18:14, Brent Yorgey wrote:
|
Hi Chris, okay. That's good to hear. It is exactly what I would like to see If no one is complaining Dotmatrix will go to contrib as package On 18.09.2015 21:35, Chris wrote:
|
Swimunit will become a versatile plotting library.
It will be possible to stack plot elements like lego pieces.
E.g.
plot # centerXY
<>
grid # centerXY
with
grid :: Diagram B
grid = (
verticlabel vml1 0.3 # fc lime
||| (
verticticks vmt1 0.4 ( 0.0) # lc lime
<>
verticticks vit1 0.2 (-1.0) # lc green
<>
verticaxis 8.5 # lc white
) |||
verticgrid vmt1 8.5 # lc blue
)
plot :: Diagram B
plot = (
ploticon xy1 (circle 0.1 # fc blue # lc aqua)
<>
plotline xy1 # lc aqua
)
plots lines and points over a grid.
See example below.
In addition a cool Dotmatrix font can render arbitrary strings as if displayed on an old dotmatrix panel.