Trees for backends #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The idea is that we can now do optimization passes on these simpler trees, and ultimately hand them off to backends.
Remember to remove this before merging into master, or once we have released a new dual-tree with the internal-d branch merged.
… down the tree Transformations implicitly have an action on everything below them in a tree. So when pushing a transformation down past a style node in a tree we have to also use the transform to act on the style. Right now the only transformable attribute we have is clipping paths, so this only showed up as a bug in certain cases when clipping was involved.
Conflicts: .travis.yml diagrams-core.cabal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is ready for merging now. diagrams-svg and diagrams-cairo have both been ported to the new
renderData/RTreeinterface.