Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return list of traces #48

Merged
merged 14 commits into from
Jan 14, 2014
Merged

return list of traces #48

merged 14 commits into from
Jan 14, 2014

Conversation

jeffreyrosenbluth
Copy link
Member

Hopefully that does it but I haven't tested the rayTrace… functions yet.

@jeffreyrosenbluth
Copy link
Member Author

Sounds good

btw you make some good points about appTrace and I'm fine it you want to use it instead of op Trace. It's partly a matter of style and I don't think its that important either.

@byorgey
Copy link
Member

byorgey commented Jan 13, 2014

@jeffreyrosenbluth , what do you think of my changes? You can see the generated Haddock documentation (with diagrams-haddock images) here: http://www.cis.upenn.edu/~byorgey/diagrams-core/Diagrams-Core-Trace.html .

Other than the SortedList changes which you already saw, I was just making improvements to the documentation.

byorgey added a commit that referenced this pull request Jan 14, 2014
@byorgey byorgey merged commit 11d5e23 into master Jan 14, 2014
@byorgey byorgey deleted the traces branch January 14, 2014 02:00
@jeffreyrosenbluth
Copy link
Member Author

@bergey - you should be able to fix your clipTo algorithm now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants