Preliminary implementation of Measure #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
master -> units
also add renderDiaT which returns a transformation (for use by end users, e.g. to convert output coordinates back into local coordinates)
|
|
||
| -- | Convert an RTree to a renderable object. The transforms have | ||
| -- been accumulated and are in the leaves of the RTree along with the Prims. | ||
| renderRTree :: RTree b v a -> Render b v |
There was a problem hiding this comment.
What's the point of putting renderRTree in the Backend class? It's not actually used by anything as far as I can tell (except being a recommended way to implement renderData).
Conflicts: src/Diagrams/Core.hs src/Diagrams/Core/Compile.hs Conflicts had to do with changes to include Annotations.
* Merge master branch into this one * Move 'toOutput' into diagrams-core, implemented generically * Wait to convert to output units until after conversion to RTree. I know this means DelayedLeaves will be broken; still thinking about how to tackle that.
* Add "generic" attributes * Finish toRTree reimplementation * Remove Options argument from renderData
* switch from syb to Data.Data.Lens * fix the type of 'convert': `Measure (Scalar v)`, not `Measure v` !
The diagram has *already* had the global -> output transformation applied, so don't multiply by that scaling factor again!
Rework units
This lets us properly express vector-space-generic V and Transformable instances for Measure.
Clean-slate redesign/simplification of `Backend` class
A mini-DSL for Measures.
byorgey
added a commit
that referenced
this pull request
Apr 7, 2014
Big refactoring! * Remove `freeze` (and hence `Split` transforms, etc.) * Add units of `Measure` * Refactor and simplify `Backend` class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please do NOT merge
In particular no arrows
Companion branches in -lib, -svg